Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: init docker alpine tests #2110

Merged
merged 10 commits into from Oct 6, 2021
Merged

feat: init docker alpine tests #2110

merged 10 commits into from Oct 6, 2021

Conversation

pantharshit00
Copy link
Contributor

This PR introduces a new docker folder which shall container all of our docker related tests.

Inside of that folder, we have a test for alpine linux for now. Mostly reusing artefacts from the pm2 test.

@pantharshit00
Copy link
Contributor Author

Actually, ready for merge. Tests failure are expected.

docker/alpine/schema.prisma Outdated Show resolved Hide resolved
@Jolg42
Copy link
Member

Jolg42 commented Oct 6, 2021

Both library and engine jobs are failing with

Error: Unable to require(`/usr/src/app/node_modules/@prisma/engines/libquery_engine-linux-musl.so.node`)

I expected the engine job the fail with the binary engine 🤔

@pantharshit00
Copy link
Contributor Author

pantharshit00 commented Oct 6, 2021

Both library and engine jobs are failing with

Error: Unable to require(`/usr/src/app/node_modules/@prisma/engines/libquery_engine-linux-musl.so.node`)

I expected the engine job the fail with the binary engine 🤔

Good catch! Looks like I forgot to pass the engine type env variable to docker.

Edit: Looks like CLI still tried to open the library file regardless of the environment variable.

@Jolg42
Copy link
Member

Jolg42 commented Oct 6, 2021

@pantharshit00 I think you'll need to use PRISMA_CLI_QUERY_ENGINE_TYPE (we use that in prisma/prisma)

@Jolg42 Jolg42 added this to the 3.3.0 milestone Oct 6, 2021
@janpio janpio merged commit 080d78e into dev Oct 6, 2021
@janpio janpio deleted the docker-alpine branch October 6, 2021 16:32
@janpio janpio mentioned this pull request Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants