Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support graphql 15? #254

Closed
fiznool opened this issue Apr 15, 2020 · 3 comments · Fixed by BigsonLvrocha/graphql-middleware#1
Closed

Support graphql 15? #254

fiznool opened this issue Apr 15, 2020 · 3 comments · Fixed by BigsonLvrocha/graphql-middleware#1

Comments

@fiznool
Copy link

fiznool commented Apr 15, 2020

graphql-js 15 is out. When installing this module, a peer dependency warning is issued when using graphql 15.
@csvan
Copy link

csvan commented Nov 15, 2020 •
edited

The install now breaks completely under npm7, unless the --legacy-peer-deps flag is passed:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: myproject@1.0.0
npm ERR! Found: graphql@15.4.0
npm ERR! node_modules/graphql
npm ERR!   graphql@"^15.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer graphql@"^0.12.0 || ^0.13.0 || ^14.0.0" from graphql-middleware@4.0.2
npm ERR! node_modules/graphql-middleware
npm ERR!   graphql-middleware@"^4.0.2" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/csvanefalk/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/csvanefalk/.npm/_logs/2020-11-15T08_30_02_978Z-debug.log

@dborstelmann
Copy link

This is breaking for me on npm7 as well, it would be great if we could support graphql 15.

@BigsonLvrocha BigsonLvrocha mentioned this issue Dec 4, 2020
Merged
BigsonLvrocha added a commit to BigsonLvrocha/graphql-middleware that referenced this issue Dec 4, 2020
@BigsonLvrocha
Merge pull request #1 from BigsonLvrocha/feat/update-library
2bee412 
- Adds support for graphql 15 (Fixes maticzav#254)
- Adds immutability (Fixes maticzav#63)
- Drops support for graphql-yoga
- Remove unused graphql-tools subpackages from dependencies
- Switches repository information and configuration
BigsonLvrocha pushed a commit to BigsonLvrocha/graphql-middleware that referenced this issue Dec 7, 2020
fix(applicator): migrate to support graphql 15
ff3ff3f 
BREAKING CHANGE: remove extra resolver properties support

Fixes maticzav#254
@BigsonLvrocha BigsonLvrocha mentioned this issue Dec 10, 2020
Merged
@github-actions
Copy link

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/update library BigsonLvrocha/graphql-middleware
3 participants
@fiznool @csvan @dborstelmann