Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): move @graphql-tools/delegate to dependencies #321

Merged

Conversation

arnaud-zg
Copy link
Contributor

Hey, I just update the library graphql-middleware to the version 6.0.0. Since then I can't build my project anymore. I noticed that the library @graphql-tools/delegate is not installed on my side, that's because it's not referenced as a dependency.

node_modules/graphql-middleware/dist/types.d.ts:2:31 - error TS2307: Cannot find module '@graphql-tools/delegate' or its corresponding type declarations.

2 import { StitchingInfo } from '@graphql-tools/delegate';
                                ~~~~~~~~~~~~~~~~~~~~~~~~~
Found 1 error.

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. 

How to reproduce?

I think i figure it out. Graphql-shield is still using an older version. If I use 4.0.0 of the middleware then it works.

Here is the reproduction repo if you want to try it out.
https://github.com/cernicc/temp

Source: #314 (comment)

@arnaud-zg arnaud-zg changed the title fix(deps): move "@graphql-tools/delegate" to dependencies fix(deps): move @graphql-tools/delegate to dependencies Jan 7, 2021
@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #321 (7ae1b45) into master (8dca5b8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #321   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          164       164           
  Branches        30        30           
=========================================
  Hits           164       164           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dca5b8...7ae1b45. Read the comment docs.

@maticzav maticzav merged commit 401a713 into maticzav:master Jan 8, 2021
@github-actions
Copy link

github-actions bot commented Jan 8, 2021

🎉 This PR is included in version 6.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants