Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VS Code quick fix / code action to phase out referentialIntegrity in favor of relationMode #1276

Closed
2 tasks
jkomyno opened this issue Nov 3, 2022 · 0 comments · Fixed by prisma/prisma-engines#3620
Closed
2 tasks

Add VS Code quick fix / code action to phase out referentialIntegrity in favor of relationMode #1276

jkomyno opened this issue Nov 3, 2022 · 0 comments · Fixed by prisma/prisma-engines#3620
Assignees
@Druue
Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. topic: code action topic: referentialIntegrity/relationMode
Projects
🌐 Language Tools Issue Categorization
Milestone
4.10.0

Comments

@jkomyno
Copy link
Contributor

jkomyno commented Nov 3, 2022

Considering the recent backward-compatible renaming of the referentialIntegrity = "prisma"|"foreignKeys" attribute to relationMode = "prisma"|"foreignKeys" and subsequent deprecation of the referentialIntegrity attribute, we should provide a VSCode quick action that:

  • replaces referentialIntegrity in favor of relationMode if both attributes exist
  • renames referentialIntegrity into relationMode if only the referentialIntegrity attribute exists

Note that the name of the preview feature, referentialIntegrity, should be left unchanged.
@jkomyno jkomyno added kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. topic: code action process/candidate Candidate for next Milestone. labels Nov 3, 2022
@jkomyno jkomyno mentioned this issue Nov 3, 2022
Merged
@Jolg42 Jolg42 changed the title Add VSCode quick action to phase out referentialIntegrity in favor of relationMode when using the referentialIntegrity preview feature Add VS Code quick action to phase out referentialIntegrity in favor of relationMode when using the referentialIntegrity preview feature Nov 8, 2022
@jkomyno jkomyno removed the process/candidate Candidate for next Milestone. label Nov 9, 2022
@janpio janpio added this to Quickfix / CodeAction in 🌐 Language Tools Issue Categorization Nov 10, 2022
@janpio janpio changed the title Add VS Code quick action to phase out referentialIntegrity in favor of relationMode when using the referentialIntegrity preview feature Add VS Code quick action to phase out referentialIntegrity in favor of relationMode Nov 23, 2022
@janpio janpio changed the title Add VS Code quick action to phase out referentialIntegrity in favor of relationMode Add VS Code quick fix / code action to phase out referentialIntegrity in favor of relationMode Nov 23, 2022
@Jolg42 Jolg42 added this to the 4.7.0 milestone Nov 24, 2022
@janpio janpio removed this from the 4.7.0 milestone Dec 1, 2022
@Druue Druue added this to the 4.9.0 milestone Jan 3, 2023
@Druue Druue modified the milestones: 4.9.0, 4.10.0 Jan 18, 2023
@Druue Druue mentioned this issue Jan 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Druue Druue

Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. topic: code action topic: referentialIntegrity/relationMode
Projects
🌐 Language Tools Issue Categorization
Quickfix / CodeAction
Milestone
4.10.0
Development

Successfully merging a pull request may close this issue.

feat(fmt): quick-fix <> referentialIntegrity -> relationMode prisma/prisma-engines
4 participants
@janpio @Jolg42 @jkomyno @Druue