The extension for VS Code ignores the modern telemetry flag

[kergian]

Bug description

The extension for VS Code ignores the telemetry flag of modern versions of the editor.

The documentation for the extension says: to disable telemetry, specify telemetry.enableTelemetry": false in the settings.
The problem is that this flag was used in past versions of VS Code and has long been declared deprecated in favor of telemetry.telemetryLevel.

The official VS Code documentation has a description of the new settings and how they work: Telemetry

So if someone uses a modern version of VS Code with the new telemetry setting flag, the extension ignores it and still goes to checkpoint.prisma.io.

How to reproduce

1. Use a modern version of VS Code
2. Set the telemetry flag to any position, the most restricted is off
3. Use any software to track/monitor network connections
4. Watch VS Code go to checkpoint.prisma.io
5. NOTE: If you set the telemetry.enableTelemetry: false flag, even though modern versions of VS Code have declared it deprecated, the extension takes it into account and does not send the request to its server

Expected behavior

The new flag should be taken into account and no request should be sent to the server

Environment & setup

• OS: macOS Ventura 13.4.1
• Editor: Visual Studio Code - Insiders
• Editor version: 1.81.0
• Extension version: 5.0.0

[janpio]

Thanks for the issue, that is definitely an oversight on our side.
We should not send any telemetry data on any level besides all - agree @kergian?

For context, this is where the deprecation was announced: https://code.visualstudio.com/updates/v1_61#_telemetry-settings

[kergian]

@janpio that's right. If the flag of the telemetry.telemetryLevel value is set to off, then any telemetry should be disabled. For other values like crash, or error there may be options.

In my estimation of what you have in your documentation, you can send a request to the server if the user specifically states in the telemetry settings that they agree to everything (setting = all), because you collect information not only on error logs but also on usage of the functionality.

For context, this is where the deprecation was announced: https://code.visualstudio.com/updates/v1_61#_telemetry-settings

Damn, literally ages ago😅

[janpio]

Raised internally and will try to get this fixed asap.
(Maybe even as a patch for the VS Code extension only, we wanted to test our patch release functionality anyway 😆)

[Jolg42]

Thanks for opening this issue, I thought this was already implemented since a long time ago (#526)
So I'll double check this!

[Jolg42]

I opened a PR to fix this and react to telemetryLevel #1465

[Jolg42]

@kergian Thanks a lot for reporting this!
We took this as an opportunity to do a patch release of the extension, it is now available as 5.0.63 (it's a weird version patch, but it's the right one!)
Now available on the marketplace

Let me know if it works as expected, I added a log in the DevTools to easily figure what's the state:

[kergian]

@Jolg42 Joël - tested it and it works! Telemetry is no longer being sent. Thanks guys! 🤩 Issue can be safely closed🚀