Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect VSCode theme and tell people to use a different one for better experience #405

Closed
carmenberndt opened this issue Aug 12, 2020 · 1 comment · Fixed by #437
Closed
Assignees
Labels
kind/improvement An improvement to existing feature and code. topic: vscode
Milestone

Comments

@carmenberndt
Copy link
Contributor

The minimal themes do not use all the root groups from the textmate grammer used for syntax highlighting, leading to a bad experience for users.

We could detect the theme and create a toast telling people about this.

@carmenberndt carmenberndt added process/candidate Candidate for next Milestone. kind/improvement An improvement to existing feature and code. topic: vscode labels Aug 12, 2020
@janpio
Copy link
Member

janpio commented Aug 13, 2020

Text suggestion:

The VSCode Color Theme foo you are using unfortunately does not fully support syntax highlighting. We suggest you switch to bar which does fully support it and will give you a better experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement An improvement to existing feature and code. topic: vscode
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants