Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to stop extension from creating .vscode folder in workspace #439

Closed
ghost opened this issue Aug 30, 2020 · 3 comments · Fixed by #443
Closed

Option to stop extension from creating .vscode folder in workspace #439

ghost opened this issue Aug 30, 2020 · 3 comments · Fixed by #443
Assignees
Labels
bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug.
Milestone

Comments

@ghost
Copy link

ghost commented Aug 30, 2020

Even if I'm not using git at all, the Prisma extension creates a .vscode/settings.json file in my workspace with the following settings:

{
    "files.watcherExclude": {
        "**/.git/objects/**": true,
        "**/.git/subtree-cache/**": true,
        "**/.hg/store/**": true
    }
}

If I remove the .vscode folder, the extension recreates it. Is there a reason for this?

@janpio janpio added bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug. labels Aug 31, 2020
@janpio
Copy link
Member

janpio commented Aug 31, 2020

I can confirm this behavior. Creating a new project with prisma init and then opening the schema in VSCode with the extension is enough to get these 4 lines added to your .vscode/settings.json (or the file being created if it does not exist yet).

@carmenberndt
Copy link
Contributor

carmenberndt commented Sep 2, 2020

Hi @joaopaulobdac!

This issue was fixed in #443.

What happened: To be able to solve the problem of hanging types, our solution was to restart the TS Language Server on every change to node_modules/.prisma/client/index.d.ts. In order to detect changes to this file, we had to change the workspace settings, otherwise changes to node_modules were ignored by default. This unfortunately lead to the creation of the .vscode/settings.json file.

We now are detecting changes with a different file watcher (chokidar), which does detect changes to the node_modules folder. Therefore no settings will be changed on your side anymore, and also no .vscode/settings.json file will be created.

Please try out 2.6.0 and let us know if there are any issue with it.

@ghost
Copy link
Author

ghost commented Sep 2, 2020

Thanks for describing what was happening behind the scenes! I already upgraded to 2.6.0, no more settings modifications here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants