Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP: With --stdio, console.log ( in printLogMessage ) breaks JSON. #571

Closed
LumaKernel opened this issue Oct 18, 2020 · 2 comments · Fixed by #609
Closed

LSP: With --stdio, console.log ( in printLogMessage ) breaks JSON. #571

LumaKernel opened this issue Oct 18, 2020 · 2 comments · Fixed by #609
Assignees
@carmenberndt
Labels
bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug.
Milestone
Backlog 2.11.0

Comments

@LumaKernel
Copy link
Contributor

SSIA.

https://github.com/prisma/language-tools/blob/master/packages/language-server/src/rename/renameUtil.ts#L176
https://github.com/prisma/language-tools/blob/master/packages/language-server/src/server.ts#L32
@LumaKernel
Copy link
Contributor Author

For example, it occurs when renaming.

@LumaKernel LumaKernel mentioned this issue Oct 18, 2020
Closed
@LumaKernel
Copy link
Contributor Author

LumaKernel commented Oct 19, 2020 •
edited

Sorry for my unclear description.
I will write more description.

Why console.log is problem?

In --stdio mode, the conversation between lsp-client ( like vim-lsp ) and this LS over stdin/stdout. console.log ( and .info, .debug ) is streaming to stdin. (What stream is used is documented here) They conflict because using the same stream in 2 purpose; the response lsp-client gets is broken by inserted logging.

@LumaKernel LumaKernel mentioned this issue Oct 19, 2020
Closed
@carmenberndt carmenberndt added bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug. labels Oct 19, 2020
@LumaKernel LumaKernel changed the title With --stdio, console.log ( in printLogMessage ) breaks JSON. LSP: With --stdio, console.log ( in printLogMessage ) breaks JSON. Oct 19, 2020
@carmenberndt carmenberndt added the process/candidate Candidate for next Milestone. label Oct 26, 2020
@janpio janpio added this to the Backlog 2.11.0 milestone Oct 28, 2020
@janpio janpio removed the process/candidate Candidate for next Milestone. label Oct 28, 2020
@carmenberndt carmenberndt mentioned this issue Nov 4, 2020
Merged
@janpio janpio modified the milestones: Release 2.11.0, Backlog 2.11.0 Nov 10, 2020
🌐 Language Tools Issue Categorization automation moved this from Bug to Closed/Done Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carmenberndt carmenberndt

Labels
bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug.
Projects
None yet
Milestone
Backlog 2.11.0
3 participants
@janpio @LumaKernel @carmenberndt