jest doesn't find scalars

[Manubi]

Hi,

"nexus-prisma": "^0.33.0",
"nexus": "^1.1.0",
"@prisma/client": "^2.30.1"
"prisma": "^2.30.1"

thanks!

[jasonkuhrt]

Is this happening for you outside of Jest too?

[Manubi]

No, just if I run jest. I know it's not a nexus-prisma bug, but I think the chances of finding a solution are bigger here? :)

[jasonkuhrt]

Yeah it might be an integration issue that we can better support (Like we did for vercel/ncc) or at least document.

This is weird.

One thing I can say is that we're using the new Node's recent support for package exports field. I think only supported since Node 12.

I wonder if Jest transpilation/pre-processing is somehow failing on this...

Are all your deps up to date?
Node 16 or 14?
Are you using ts-jest?
What does your jest config look like?

If all your deps are not up to date I would start there. And use Node 16 or 14 if 16 not possible for you.

[Manubi]

Hey,

deps are all up to date. Also tried the moduleMapper in the jest config without success. Any other ideas?

node: v 16.8.0
"jest": "^27.1.0"
"nexus-prisma": "^0.33.0",
"nexus": "^1.1.0",

jest config in package.json

  "jest": {
    "setupFiles": [
      "dotenv/config"
    ],
    "setupFilesAfterEnv": [
      "./src/test/jest-setup.ts"
    ],
    "transform": {
      "\\.tsx?$": [
        "babel-jest",
        {
          "configFile": "./.babelrc.jest.js"
        }
      ]
    }
  },

[jasonkuhrt]

Can you share a repo repro?

[Manubi]

I would need to make one. Will you look into it if I make one? 😄

[jasonkuhrt]

@Manubi yep if its not massive 😅

[Manubi]

Sorry, didn't have time to make a repo repro.
But, jestjs/jest#9771 looks like Jest has still problems with importing from exports in the package.json. Not sure what a good solution would be.

[sachinraja]

eslint-plugin-import is also erroring import/no-unresolved for nexus-prisma/scalars. I believe it has to do with this change as I only got the error after updating. The import works fine though, the scalars still show up in my schema.

Both jest and eslint-plugin-import support for exports seem to be blocked by browserify/resolve#222. The only solution I see is providing cjs paths (a scalars.js file in the root directory). This is what next.js does (see file tree).

[jasonkuhrt]

We used to have the old system.

If I bring it back it seems that it will support old systems still transitioning to ESM

[jasonkuhrt]

I'm convinced to bring back the old system. Will try to push a fix for this soon. If someone wants to go in the git history and pull it back out into a new pr please do

[sachinraja]

Can't we just add a scalars.js that re-exports dist-cjs/entrypoints/scalars.js to the root dir?

Also I believe the esm files should have the file extension .mjs as this package is not marked as "type": "module" (I think this is the cause of #142). I don't think the typescript compiler has the ability to do this, but babel certainly can if you are willing to add it (I can also attempt a PR). If not, we could just have a script that renames the dist-esm files to have the .mjs extension.

[jasonkuhrt]

Yes this is what we used to do. Again just look in the git history. We had a script that built the facade files before publishing. We did not commit them to the repo.

[jasonkuhrt]

About .mjs I am waiting for TS to do this, it should land later this year.

[sachinraja]

Yes this is what we used to do. Again just look in the git history. We had a script that built the facade files before publishing.

Oh sorry, I should have looked first.

About .mjs I am waiting for TS to do this, it should land later this year.

Correct me if I'm wrong, but I don't think the TS team has plans for that looking at microsoft/TypeScript#18442. The ESM files cannot be imported otherwise and dist-esm is useless. Also a simple rename wouldn't be too difficult renamer -regex --find '\.js^' --replace '.mjs' './dist-esm/**/*.js'.

I understand if you don't want to do this though, just suggesting in case you do still want to have cjs and esm builds.

[jasonkuhrt]

Correct me if I'm wrong, but I don't thin

I haven't followed that issue too closely, my plan was to wait for it to be closed and see what the outcome was.

[Manubi]

Hey,
jest added a resolver field in the latest version v27.0.2 . Does anyone know how that setup should look like in order to work with nexus-prisma? 😶‍🌫️ Because I think it should fix this problem. Correct? 😄

[jasonkuhrt]

Hm! If someone figures this out and wants to send docs to NP that would be great.