Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: move semantic-release under optionalDependencies #379

Merged
merged 3 commits into from Jan 16, 2023

Conversation

rostislav-simonik
Copy link
Collaborator

semantic-release is supporting only the latest LTS node release, what's causing failures for tests with older LTS node releases. But actually, it's needed only for release workflow that runs on the latest LTS release. Moving under optionalDependencies will solve the issue.

@rostislav-simonik rostislav-simonik added the type/chore Something that does not warrant a release, zero runtime impact label Jan 16, 2023
@rostislav-simonik rostislav-simonik merged commit aab61f1 into main Jan 16, 2023
@rostislav-simonik rostislav-simonik deleted the make-semantic-relaese-optional-dependency branch January 16, 2023 19:34
rostislav-simonik-nexus-prisma-admin pushed a commit that referenced this pull request Jan 30, 2023
## [1.0.4](v1.0.3...v1.0.4) (2023-01-30)

### CI

* avoid concurent execution of tests on PRs ([#381](#381)) ([7ce9aaa](7ce9aaa))
* double workflow timeouts ([#382](#382)) ([77dfa4b](77dfa4b))
* enable main release ([#368](#368)) ([dc0e45a](dc0e45a))
* move semantic-release under optionalDependencies ([#379](#379)) ([aab61f1](aab61f1))
* remove on push trigger for release workflow ([#369](#369)) ([d82617b](d82617b))
* switch to current lts node version 18 ([#365](#365)) ([b1abba8](b1abba8))

### Bug fixes

* **deps:** update dependency tslib to ^2.5.0 ([#409](#409)) ([1c38ddf](1c38ddf))
* **docs:** edit page on github ([#372](#372)) ([ae266a3](ae266a3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore Something that does not warrant a release, zero runtime impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant