Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for BigInt scalar #59

Closed
jasonkuhrt opened this issue May 25, 2021 · 2 comments · Fixed by #56
Closed

Add support for BigInt scalar #59

jasonkuhrt opened this issue May 25, 2021 · 2 comments · Fixed by #56
Assignees
@jasonkuhrt
Labels
community/help-wanted Not our focus, but accepting PRs scalars Related to GraphQL scalars, Prisma scalars, etc. type/feat Add a new capability or enhance an existing one

Comments

@jasonkuhrt
Copy link
Member

jasonkuhrt commented May 25, 2021 •
edited
Loading

Perceived Problem

Ideas / Proposed Solution(s)

  • Use https://www.graphql-scalars.dev/docs/scalars/big-int

  • Mention which Node version is needed to support this

  • watch out for this:

    In order to support BigInt in JSON.parse and JSON.stringify, it is recommended to install this npm package together with this scalar. Otherwise, JavaScript will serialize the value as string. json-bigint-patch
@jasonkuhrt jasonkuhrt added the type/feat Add a new capability or enhance an existing one label May 25, 2021
@jasonkuhrt jasonkuhrt mentioned this issue May 25, 2021
Merged
2 tasks
@jasonkuhrt jasonkuhrt added scalars Related to GraphQL scalars, Prisma scalars, etc. community/help-wanted Not our focus, but accepting PRs labels May 25, 2021
@jasonkuhrt jasonkuhrt pinned this issue Jun 23, 2021
@jasonkuhrt jasonkuhrt assigned jasonkuhrt and unassigned jasonkuhrt Jul 7, 2021
@iddan
Copy link
Collaborator

iddan commented Jul 8, 2021

I think this can be unpinned

@jasonkuhrt jasonkuhrt unpinned this issue Jul 8, 2021
@rostislav-simonik-nexus-prisma-admin
Copy link
Collaborator

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonkuhrt jasonkuhrt

Labels
community/help-wanted Not our focus, but accepting PRs scalars Related to GraphQL scalars, Prisma scalars, etc. type/feat Add a new capability or enhance an existing one
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support for BigInt scalar iddan/nexus-prisma
3 participants
@jasonkuhrt @iddan @rostislav-simonik-nexus-prisma-admin