All Engines should print commit hash on startup

[mavilein]

@timsuchanek wants to use this to validate that the javascript code and downloaded engines are in sync. We often had the case that this did not work properly and debugging is unecessarily hard.

[pimeys]

We have this now when querying /server_info from the query-engine runtime.

[pimeys]

We have this also in the command line parameters for query and migration engines:

cargo run --bin prisma -- --version
2b78c35cf302bf80ae5aaa863c5eee0d09541f83

cargo run --bin migration-engine -- --version
2b78c35cf302bf80ae5aaa863c5eee0d09541f83

[pimeys]

fe8f5f7

[janpio]

How will this be implemented/used?

[pimeys]

You just run the binary with --version parameter.

[janpio]

Ha, yes on the engine side - I was wondering where and how this would be used by @timsuchanek to do what exactly.

[pimeys]

When we cut a release, photon asserts the hash and throws if it's not what is expected.

…

-------- Original Message --------

On Oct 9, 2019, 00:46, Jan Piotrowski wrote: Ha, yes on the engine side - I was wondering where and how this would be used by ***@***.***(https://github.com/timsuchanek) to do what exactly. — You are receiving this because you modified the open/close state. Reply to this email directly, [view it on GitHub](#35), or [mute the thread](https://github.com/notifications/unsubscribe-auth/AAAIRF7JTO2VXHZEIR4J6Y3QNUESRANCNFSM4IUKYG4A).