Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Engine: Find a replacement for our current logger (performance) #91

Closed
mavilein opened this issue Oct 9, 2019 · 3 comments
Closed
Assignees
Milestone

Comments

@mavilein
Copy link
Member

mavilein commented Oct 9, 2019

This is a followup task from this issue.

During benchmarking we found out that our current logger implementation is very slow and in some cases can consume 50% of CPU cycles while processing a simple query. We want to replace the current logger we use. The idea is to evluate tokio tracing for which we need write our own json output formatter.

@mavilein mavilein added this to the Preview 14 milestone Oct 9, 2019
@pimeys
Copy link
Contributor

pimeys commented Oct 9, 2019

https://github.com/tokio-rs/tracing/ is very promising from a performance point of view. We need to write a json subscriber to it though.

@mavilein
Copy link
Member Author

This is done but not merged to master yet. We first need input from @timsuchanek whether those changes are ok for him. They might affect how the js side must consume the log.

@timsuchanek
Copy link
Contributor

This has been merged and is available in alpha.

miguelff pushed a commit that referenced this issue Apr 20, 2023
Add support for money columns on postgres
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants