Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enum names must be validated that they are not using a reserved name #1052

Closed
mavilein opened this issue Aug 20, 2020 · 0 comments · Fixed by #1065
Closed

Enum names must be validated that they are not using a reserved name #1052

mavilein opened this issue Aug 20, 2020 · 0 comments · Fixed by #1065
Assignees
@carmenberndt
Labels
tech/engines/datamodel Issue about parsing/validation/rendering of the Prisma schema tech/engines Issue for tech Engines.
Milestone
Release 2.6.0

Comments

@mavilein
Copy link
Member

While skimming our code i realized that we probably not validating the name of enums correctly. E.g. an enum with name StringFilter would be possible which would crash our schema building in the query engine. We should apply the same validation as for model names. Take a look at reserved_model_names.rs.
@mavilein mavilein added process/candidate tech/engines/datamodel Issue about parsing/validation/rendering of the Prisma schema tech/engines Issue for tech Engines. labels Aug 20, 2020
@mavilein mavilein added this to the Backlog 2.6.0 milestone Aug 20, 2020
@carmenberndt carmenberndt mentioned this issue Aug 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carmenberndt carmenberndt

Labels
tech/engines/datamodel Issue about parsing/validation/rendering of the Prisma schema tech/engines Issue for tech Engines.
Projects
None yet
Milestone
Release 2.6.0
Development

Successfully merging a pull request may close this issue.

validate enum names prisma/prisma-engines
2 participants
@mavilein @carmenberndt