Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ScalarType Xml #1283

Closed
mavilein opened this issue Oct 22, 2020 · 1 comment · Fixed by #1289
Closed

Remove ScalarType Xml #1283

mavilein opened this issue Oct 22, 2020 · 1 comment · Fixed by #1289
Assignees
Labels
tech/engines/datamodel Issue about parsing/validation/rendering of the Prisma schema tech/engines/introspection engine Issue in the Introspection Engine tech/engines/migration engine Issue in the Migration Engine tech/engines/query engine Issue in the Query Engine tech/engines Issue for tech Engines.

Comments

@mavilein
Copy link
Member

We decided to remove the scalar type Xml because it does not add real value.
This means that the following schema is not possible anymore:

model Blog {
  id  Int @id
  xml Xml
}

Instead users will have to write it like this:

model Blog {
  id  Int @id
  xml String @mydb.Xml
}
@mavilein mavilein added tech/engines/migration engine Issue in the Migration Engine tech/engines/query engine Issue in the Query Engine tech/engines/introspection engine Issue in the Introspection Engine tech/engines/datamodel Issue about parsing/validation/rendering of the Prisma schema tech/engines Issue for tech Engines. labels Oct 22, 2020
@mavilein mavilein added this to the Backlog 2.10.0 milestone Oct 22, 2020
@mavilein
Copy link
Member Author

mavilein commented Oct 23, 2020

Tasks:

  • adapt parser
  • adapt introspection
  • do not touch query engine with PrismaValue etc. We want to do this to save some effort.
  • adapt ME (might be needed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech/engines/datamodel Issue about parsing/validation/rendering of the Prisma schema tech/engines/introspection engine Issue in the Introspection Engine tech/engines/migration engine Issue in the Migration Engine tech/engines/query engine Issue in the Query Engine tech/engines Issue for tech Engines.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants