Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse type names in datamodel parser at the pest level instead of regular expressions #1917

Closed
tomhoule opened this issue May 11, 2021 · 0 comments · Fixed by #1941
Closed

Parse type names in datamodel parser at the pest level instead of regular expressions #1917

tomhoule opened this issue May 11, 2021 · 0 comments · Fixed by #1941
Labels
team/schema Issue for team Schema.
Milestone
2.24.0

Comments

@tomhoule
Copy link
Contributor

This became apparent again in #1912

We should not be doing regex matching on coarse AST nodes, but instead have Unsupported("abcd") be at least two nodes: Unsupported and "abcd" (parsed like other string literals).

This would be a start in refactoring field type lifting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team/schema Issue for team Schema.
Projects
None yet
Milestone
2.24.0
Development

Successfully merging a pull request may close this issue.

Improve parsing of Unsupported(...) prisma/prisma-engines
1 participant
@tomhoule