ctx and Prisma instance question

[brikou]

Hi great repo, 1.17 looks fantastic!

I have a real question: why do you attach prisma to context instead of doing a regular import of the instance?

[timsuchanek]

@brikou the reason is, that when you want to use the Dataloader with full Cache later, you don't need to change your code. So this basically means, that on each request, a new Client instance is created. It's not used right now, but will later help to enable caching on a request basis.

Does this answer your question?

[brikou]

Ok I see but since cache is not used, we should remove it. Then add an example with this cache feature. Thanks for your insight.

[abhiaiyer91]

The intention of this is to establish patterns we think will help for working with Prisma. By attaching the Prisma within context, we establish a pattern for your code that can take advantage of caching once we enable that feature. When we release it people can take advantage of it for free.

By all means though import Prisma in your own files if it makes sense for you

[brikou]

Thanks @abhiaiyer91, can't wait to see the cache feature coming