ExpressionKind members have large size differences

[yoshuawuyts]

quaint/src/ast/expression.rs

Line 170 in 95be465

Function(Function<'a>),

and

quaint/src/ast/table.rs

Line 22 in fa99f53

Query(Select<'a>),

are marked by clippy as 500 bytes, with the second-largest member being 40 bytes. Adding an intermediate box will likely help improve allocations / performance.

You can get this output by running:

$ cargo +nightly clippy

Thanks!

Output

warning: large size difference between variants
   --> src\ast\expression.rs:170:5
    |
170 |     Function(Function<'a>),
    |     ^^^^^^^^^^^^^^^^^^^^^^ this variant is 536 bytes
    |
    = note: `#[warn(clippy::large_enum_variant)]` on by default
note: and the second-largest variant is 40 bytes:
   --> src\ast\expression.rs:162:5
    |
162 |     RawValue(Raw<'a>),
    |     ^^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
help: consider boxing the large fields to reduce the total size of the enum
    |
170 |     Function(Box<Function<'a>>),
    |              ^^^^^^^^^^^^^^^^^

warning: large size difference between variants
  --> src\ast\table.rs:22:5
   |
22 |     Query(Select<'a>),
   |     ^^^^^^^^^^^^^^^^^ this variant is 296 bytes
   |
note: and the second-largest variant is 32 bytes:
  --> src\ast\table.rs:21:5
   |
21 |     Table(Cow<'a, str>),
   |     ^^^^^^^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
help: consider boxing the large fields to reduce the total size of the enum
   |
22 |     Query(Box<Select<'a>>),
   |           ^^^^^^^^^^^^^^^