Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

fix: mark seed script as ESM after transform #23

Merged
merged 6 commits into from Sep 27, 2021
Merged

fix: mark seed script as ESM after transform #23

merged 6 commits into from Sep 27, 2021

Conversation

sdnts
Copy link
Contributor

@sdnts sdnts commented Sep 27, 2021

This allows the seed script to use top-level await with Node 14, which the Babel plugin generates

@sdnts sdnts self-assigned this Sep 27, 2021
@sdnts sdnts marked this pull request as draft September 27, 2021 09:11
@sdnts sdnts removed the request for review from jasonkuhrt September 27, 2021 09:11
@sdnts
Copy link
Contributor Author

sdnts commented Sep 27, 2021

Might need more changes, marking as draft till I figure out what they all are.

@sdnts
Copy link
Contributor Author

sdnts commented Sep 27, 2021

Okay done.

I've made changes in Cloud to start seeding via an ESM script, so these changes are required here. More details in the Slack message on #engineering-developer-productivity that I'm going to write.

@sdnts sdnts marked this pull request as ready for review September 27, 2021 11:17
@jasonkuhrt
Copy link
Member

Copy link
Member

@jasonkuhrt jasonkuhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sdnts sdnts merged commit a787a83 into main Sep 27, 2021
@sdnts sdnts deleted the fix/seed branch September 27, 2021 12:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants