Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1 compatible version #11

Closed
lstwn opened this issue Jul 18, 2019 · 8 comments
Closed

v1 compatible version #11

lstwn opened this issue Jul 18, 2019 · 8 comments
Assignees
Labels
kind/feature A request for a new feature. topic: prisma1

Comments

@lstwn
Copy link

lstwn commented Jul 18, 2019

Hey guys,

as much as I am looking forward to using Prisma 2 and especially the new datamodel since it includes much needed features, I am a bit aghast about the way the transition is handled.

Let's be honest, Prisma 2 is not even a mature thing yet and production-readiness is also a thing for the future. Right now we have .prisma files in the v1 schema and are definitely stuck with them for a while, but since you are updating this plugin to match the v2 schema already, wouldn't it be nice to leave a v1-compatible version out here?

@Badyl1g
Copy link

Badyl1g commented Jul 26, 2019

I completely agree, I read that Prisma 1 would be maintained without breaking changes, and now there's no way to have syntax highlighting for v.1 datamodel

@cmoses8626
Copy link

Totally agree. My .prisma v1 file looks FUBAR'd now. Could you guys release a v1 plugin? While Prisma 2 looks exciting, I don't have time right now to do any upgrades, and can't right now anyways as it's not yet production ready.

@mariobermudezjr
Copy link

mariobermudezjr commented Aug 10, 2019

I have a temporary solution:

In your prisma.yml file change datamodel.prisma to datamodel.graphql

and finally change your datamodel.prisma filename to datamodel.graphql

whalaaa!

@sejr
Copy link

sejr commented Aug 27, 2019

Yeah, this is extremely frustrating. @ejoebstl @schickling @matthewmueller any thoughts?

@schickling
Copy link
Member

Thanks a lot for all of your feedback. I agree we should have come up with a better solution in regards to compatibility and we'll make sure to handle situations like these more thoughtfully in the future. 🙏

While there are currently no plans to release a Prisma 1 compatible version of this VSCode Plugin (for capacity reasons – PRs welcome!), I suggest to go with the workaround @mariobermudezjr has suggested.

@schickling
Copy link
Member

Keeping this issue open in case some one wants to submit a PR that adds backwards compatibility.

@schickling schickling reopened this Aug 28, 2019
@janpio janpio added the kind/feature A request for a new feature. label Sep 2, 2019
@schickling schickling added the process/candidate Candidate for next Milestone. label Mar 4, 2020
@janpio janpio removed the process/candidate Candidate for next Milestone. label Mar 15, 2020
@nealoke
Copy link

nealoke commented May 27, 2020

Is it possible to just create another plugin for v1? Now all projects in which we use v1 can no longer use the handy plugin.

Nevermind, you can install an older version of a VS code extension

@thebiglabasky
Copy link

Hi,
I wanted to chime in since we've released Prisma 2 in GA in June, and propose upgrade guides in our docs.
We don't have plans to provide backwards compatibility but hope upgrading to Prisma 2 will enable more flexibility and control.
I'll thus close this issue.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A request for a new feature. topic: prisma1
Projects
None yet
Development

No branches or pull requests

10 participants