Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output version of prisma-fmt that is being executed #125

Merged
merged 4 commits into from May 5, 2020

Conversation

carmenberndt
Copy link
Contributor

closes #80

@carmenberndt
Copy link
Contributor Author

versionOutput

@@ -74,6 +74,10 @@ connection.onInitialize(async (params: InitializeParams) => {
connection.console.error('Cannot install prisma-fmt: ' + err)
}
}
connection.console.info(
'Installed version of Prisma plugin prisma-fmt: ' +

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about the word "plugin"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think would be better here?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just "Installed version of Prisma:". All binaries are and will be on the same version right?

I haven't seen plugin been used with Prisma yet and in future it might be used in a different context.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I think saying only "installed version of Prisma" might be confusing with the actual version of Prisma, e.g. "0.0.40". How about "Installed version of binaries: "? @janpio what do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Prisma binary `prisma-fmt`" maybe?

"plugin" is not the right term, and just "Prisma" is indeed confusing.

@carmenberndt carmenberndt added this to the Beta 5 milestone May 5, 2020
@carmenberndt carmenberndt merged commit 2e1b6c9 into master May 5, 2020
@carmenberndt carmenberndt deleted the showVersionOfBinaries branch May 5, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to find version/hash of prisma-fmt that is being executed?
4 participants