New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output version of prisma-fmt that is being executed #125
Conversation
server/src/server.ts
Outdated
@@ -74,6 +74,10 @@ connection.onInitialize(async (params: InitializeParams) => { | |||
connection.console.error('Cannot install prisma-fmt: ' + err) | |||
} | |||
} | |||
connection.console.info( | |||
'Installed version of Prisma plugin prisma-fmt: ' + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about the word "plugin"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think would be better here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just "Installed version of Prisma:". All binaries are and will be on the same version right?
I haven't seen plugin been used with Prisma yet and in future it might be used in a different context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm I think saying only "installed version of Prisma" might be confusing with the actual version of Prisma, e.g. "0.0.40". How about "Installed version of binaries: "? @janpio what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Prisma binary `prisma-fmt`" maybe?
"plugin" is not the right term, and just "Prisma" is indeed confusing.
closes #80