Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Think about special kind of Hook that would allow implementing resolvers cache. #14

Closed
pie6k opened this issue Apr 16, 2018 · 1 comment
Labels
discussion enhancement New feature or request

Comments

@pie6k
Copy link
Collaborator

pie6k commented Apr 16, 2018

No description provided.

@pie6k pie6k added enhancement New feature or request discussion labels Apr 16, 2018
@pie6k
Copy link
Collaborator Author

pie6k commented Apr 16, 2018

I was thinking about this a bit and actually, I've changed my mind to NOT add this.

I'm starting to have strong opinion that caching should be domain of resolver function itself. Adding some 'top-layer' for such scenario might be good for some, but limiting for others.

While I believe @before and @after hooks have some reasonable use-cases, another type of hooks that is able to interrupt resolver workflow might be wrong direction.

I'd see typegql more like library with as transparent as possible API rather than framework.

If there will be no external input about it, I'll close issue without adding such Hooks.

@pie6k pie6k closed this as completed Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant