New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use relative paths in tools #55

Closed

roblabla opened this issue Aug 31, 2015 · 2 comments

Labels

Member

roblabla commented Aug 31, 2015

Some tools use relative paths (e.g. https://github.com/PrismarineJS/minecraft-data/blob/1.8/tools/js/wiki_extractor/protocol_extractor.js#L53), which leads to them not working properly when used from another directory. They should instead use __dirname to behave properly at all times.

The text was updated successfully, but these errors were encountered:

roblabla added bug extraction labels

Member

rom1504 commented Sep 1, 2015

Yeah agreed.

Member

rom1504 commented Oct 16, 2015

Fixed. (see https://github.com/PrismarineJS/mcdevs-wiki-extractor/blob/master/bin/protocol_to_json.js)

rom1504 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment