Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks.fromProperties not always returns a Block #72

Open
sertonix opened this issue Aug 12, 2022 · 0 comments
Open

Blocks.fromProperties not always returns a Block #72

sertonix opened this issue Aug 12, 2022 · 0 comments

Comments

@sertonix
Copy link
Contributor

sertonix commented Aug 12, 2022

Blocks.fromProperties can return the raw data of a block instead of an instance of the class Block. There either should be an error or the block in the default state.

code (shortened):

static fromProperties (typeId, properties, biomeId) {
  const block = typeof typeId === 'string' ? registry.blocksByName[typeId] : registry.blocks[typeId]

  if (version.type === 'pc') {
    // ...
  } else if (version.type === 'bedrock') {
    // ... tries to find state id
    return block // should be error or instantce of Block
  }
}
@sertonix sertonix changed the title Blocks.fromProperties not always returns Block Blocks.fromProperties not always returns a Block Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant