Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Before/After/Each with Tape #32

Closed
nwinch opened this issue Apr 15, 2016 · 5 comments
Closed

Before/After/Each with Tape #32

nwinch opened this issue Apr 15, 2016 · 5 comments

Comments

@nwinch
Copy link
Contributor

nwinch commented Apr 15, 2016

@davidbanham This todo..

Potentially use a before/after/each plugin for Tape

Before/after is fairly trivial:

function beforeAfter(description, cb) {
  test(description, (t) => {
    // before promise
    someKindaPromise.then(thing => {
      cb(t).then(() => {
        // after promise
      });
    });
  });
}

Can easily split that up if both aren't needed, but the bones are there. I'm sure I was making a repo for some tape utils some time ago.. must've not finished it. I'll see if I can dig it up.

... or just switch to Mocha

I'd vote Mocha, but tape is pretty well stuck in there now..

@davidbanham
Copy link
Contributor

If we want to get away from tape now is the time to do it. It's still a pretty straightforward process.

I think the main criteria for the decision is "If people want to use our thing and they see that means being tied to tape, will they be cool with it or run away?"

@nwinch
Copy link
Contributor Author

nwinch commented Apr 15, 2016

How do we answer that? Internally we can poll mocha vs tape usage, give opinions, but not sure how we'd answer that question directly, other than mapping our own data loosely on to the community to make an assumption?

@davidbanham
Copy link
Contributor

I think we need to answer this qualitatively rather than quantitatively.

We could, though, look at the number of things that depend on Tape vs the things that depend on Mocha and decide whether the gulf is so vast that it's an obvious choice.

@kaievns
Copy link
Contributor

kaievns commented Apr 18, 2016

oh, i've just noticed the thread. i've posted a new issue #37 about mocha. and that is one of the things why i prefer mocha over tape. it's so much more practical with this sort of things

@nwinch
Copy link
Contributor Author

nwinch commented Apr 18, 2016

I'll close this as the "before/after" issue part has been answered, and we can continue Tape vs Mocha in #37.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants