Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI with various TypeScript verions #274

Closed
lihbr opened this issue Jan 3, 2023 · 0 comments
Closed

Run CI with various TypeScript verions #274

lihbr opened this issue Jan 3, 2023 · 0 comments
Labels
enhancement New feature or request v7 Getting addressed or related to version 7 of the kit

Comments

@lihbr
Copy link
Member

lihbr commented Jan 3, 2023

Is your feature request related to a problem? Please describe.

In 2022 we encountered a few nasty edge-case-y-TypeScript-issues related to some specific TypeScript versions (partly because TypeScript is complex and doesn't strictly follow SemVer)

Describe the solution you'd like

To attempt to catch those issues early we could update the CI to run type tests against various TypeScript versions. zod does so following a matrix strategy for example: https://github.com/colinhacks/zod/blob/master/.github/workflows/test.yml#L11-L27

Since this package is the only one with critical types, I don't think it's worth the overhead to port this solution to other SDKs or the template for now (or maybe just React/Vue)

Describe alternatives you've considered

Doing nothing is a also valid option 🤷‍♀️

Additional context

In an attempt to mitigate these issues we already started to systematically type check our projects as part of our test suite, e.g. https://github.com/prismicio/prismic-client/blob/v7/package.json#L49

@lihbr lihbr added enhancement New feature or request v7 Getting addressed or related to version 7 of the kit labels Jan 3, 2023
@lihbr lihbr closed this as completed Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v7 Getting addressed or related to version 7 of the kit
Projects
None yet
Development

No branches or pull requests

1 participant