Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align helpers to fn(field, options) interface #283

Closed
lihbr opened this issue Apr 11, 2023 · 0 comments
Closed

Align helpers to fn(field, options) interface #283

lihbr opened this issue Apr 11, 2023 · 0 comments
Labels
enhancement New feature or request v7 Getting addressed or related to version 7 of the kit

Comments

@lihbr
Copy link
Member

lihbr commented Apr 11, 2023

Is your feature request related to a problem? Please describe.

Right now helpers interfaces aren't consistent:

  • Some are fn(field, option1, option2, ...)
  • Other are fn(field, options)

Describe the solution you'd like

Aligning all helpers to fn(field, options) interface, deprecated but still supporting fn(field, option1, option2, ...) interface.

This mainly impact asLink and asHTML helpers.

Describe alternatives you've considered

Doing nothing -> inconsistent interfaces

Additional context

(internal): https://prismic-team.slack.com/archives/D01UP4FN3PX/p1681156796335669
@lihbr lihbr added enhancement New feature or request v7 Getting addressed or related to version 7 of the kit labels Apr 11, 2023
@lihbr lihbr mentioned this issue May 2, 2023
Merged
7 tasks
@lihbr lihbr closed this as completed May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request v7 Getting addressed or related to version 7 of the kit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lihbr