Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename Custom Type-related methods to include "CustomType" #2

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

angeloashmore
Copy link
Member

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This PR renames all Custom Type-related methods could include a "CustomType" identifier, just like the Shared Slice-related methods.

The existing methods are still included in the client as aliases, but are deprecated. Please upgrade to the renamed methods.

Old:

const customTypeModels = await client.getAll();
const sharedSliceModels = await client.getAllSharedSlices();

New:

const customTypeModels = await client.getAllCustomTypes();
const sharedSliceModels = await client.getAllSharedSlices();

Closes #1

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

馃惌

@angeloashmore angeloashmore merged commit 999b3f7 into main Mar 17, 2022
@angeloashmore angeloashmore deleted the aa/custom-type-rename branch March 17, 2022 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Custom Type-related methods to include "CustomType"
1 participant