Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove deprecated getAll(), getByID(), insert(), update(), and remove() methods #4

Merged
merged 3 commits into from
Sep 3, 2022

Conversation

angeloashmore
Copy link
Member

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This PR removes the following previously deprecated methods:

  • getAll()
  • getByID()
  • insert()
  • update()
  • remove()

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

@github-actions
Copy link

github-actions bot commented Sep 3, 2022

size-limit report 📦

Path Size
dist/index.mjs 898 B (-4.37% 🔽)
dist/index.cjs 1.14 KB (-3.39% 🔽)

@codecov-commenter
Copy link

Codecov Report

Merging #4 (2f60ee4) into main (c31d608) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              main        #4    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            3         3            
  Lines           60       581   +521     
  Branches        10        29    +19     
==========================================
+ Hits            60       581   +521     
Impacted Files Coverage Δ
src/client.ts 100.00% <100.00%> (ø)
src/errors.ts 100.00% <100.00%> (ø)
src/index.ts 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@angeloashmore angeloashmore merged commit 05dcb18 into main Sep 3, 2022
@angeloashmore angeloashmore deleted the aa/v1 branch September 3, 2022 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants