Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type context, components in SliceZoneProps #159

Merged

Conversation

Vorseek
Copy link
Contributor

@Vorseek Vorseek commented Jun 26, 2022

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fix types context in components props, for SliceZone

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

cat

@codecov-commenter
Copy link

Codecov Report

Merging #159 (71fecf6) into master (b630f12) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #159   +/-   ##
=======================================
  Coverage   91.61%   91.61%           
=======================================
  Files          18       18           
  Lines         334      334           
  Branches       84       84           
=======================================
  Hits          306      306           
  Misses          5        5           
  Partials       23       23           
Impacted Files Coverage Δ
src/SliceZone.tsx 84.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b630f12...71fecf6. Read the comment docs.

@angeloashmore
Copy link
Member

Thanks for the fix, @Vorseek! 😸

This will be published in the next release.

@angeloashmore angeloashmore merged commit edb21ec into prismicio:master Jun 27, 2022
@dturkington49
Copy link

Currently blocked by this issue. Is a release possible in the coming days?

@angeloashmore
Copy link
Member

Hi @dturkington49, thanks for the reminder. I was waiting to bundle this fix with other changes, but we haven't had to fix anything since this bug.

I just published it as v2.4.3. You should be able to update to the latest version with the following command:

npm install @prismicio/react@latest

If that doesn't fix your issue, please let me know by opening a new issue or commenting here. Thanks! 🙂

@dturkington49
Copy link

@angeloashmore Wow, thanks for the quick response! Upgraded to 2.4.3 and I'm unblocked. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants