-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only standard tag element serializers supported #48
Comments
Hey @dcecile , it makes a lot of sense. The |
Thanks, looking forward to it! I was able to work around this initially using a CSS rule for |
@hypervillain We'd also like to substitute I don't see the new code yet, so can you update this issue once the feature is released? We'd start using it right away instead of doing a workaround that would involve HTML building or element replacing. |
Hey, thanks for your patience, I just merged a PR that should better handle different element types. Thank you for reporting this @dcecile |
@hypervillain OK thanks, we'll take a look! 👀 |
Awesome! It's been deployed as a minor version bump
…On Thu, Mar 12, 2020 at 1:50 PM Dan Cecile ***@***.***> wrote:
@hypervillain <https://github.com/hypervillain> OK thanks, we'll take a
look! 👀
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#48 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSDRAIIZ76PJCQXQFOZX4TRHDK75ANCNFSM4KQXZKDQ>
.
|
I tried to override
elements={{[Elements.image]: CustomImage}}
, but got a confusing error:This is because for any custom elements, the library only provides children, which is invalid in the case of
img
.Maybe in the places where
createElement('...', ...)
is used inrichtext.js
, try checkingelements
first?The text was updated successfully, but these errors were encountered: