Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typings missing from NPM publish #52

Closed
ryan-codingintrigue opened this issue Mar 13, 2020 · 8 comments
Closed

Typings missing from NPM publish #52

ryan-codingintrigue opened this issue Mar 13, 2020 · 8 comments

Comments

@ryan-codingintrigue
Copy link

The typings folder appears to be missing from the published NPM package:

https://unpkg.com/browse/prismic-reactjs@1.3.0/

Not sure if this is intentional or not, given that it's in the package.json seems like this might me a mistake...

@cyrilchapon
Copy link
Contributor

It's manually .npmignored here; thus making the package.json typings field unworking.

@ohlr
Copy link
Contributor

ohlr commented May 5, 2020

ff8a1c5
@cyrilchapon when will this be released?

@cyrilchapon
Copy link
Contributor

I have no clue my friend; just quickly PRed this to get this done.

@cyrilchapon
Copy link
Contributor

@ohlr ; hum; it's live actually.

@ohlr
Copy link
Contributor

ohlr commented May 5, 2020

ah sorry I only looked at the releases here on github which are not actively maintained

@codingwithchris
Copy link

codingwithchris commented Jul 5, 2020

Any update on this? I am seeing the typings/index.d.ts file in the actual node modules package but my project still isn't recognizing it:

Could not find a declaration file for module 'prismic-reactjs'

On v1.3.1.

Also, FWIW, upon inspection of the file, Typescript is complaining about a lot of errors. I'm getting no less than 23 errors.

Examples:
Screen Shot 2020-07-05 at 2 45 02 PM

@codingwithchris
Copy link

Ahh... seeing now that this is directly related to #62 and #61.

@angeloashmore
Copy link
Member

Hey everyone, I know this is an old issue, but here's a quick update.

@prismicio/react v2 was just published and is now written completely in TypeScript. Going forward, all types will be maintained alongside the source code and in @prismicio/types.

Thanks for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants