Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log error by default #151

Closed
Rokt33r opened this issue Jul 30, 2020 · 0 comments · Fixed by #180
Closed

Log error by default #151

Rokt33r opened this issue Jul 30, 2020 · 0 comments · Fixed by #180

Comments

@Rokt33r
Copy link
Member

Rokt33r commented Jul 30, 2020 •
edited

The default error handler doesn't use console.log. It makes debugging with prismy really difficult.
https://github.com/prismyland/prismy/blob/master/src/error.ts

What to do

  • Add silent option. It should be false by default
  • Use console.error(...)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 151: Log error by default prismyland/prismy
1 participant
@Rokt33r