Migrate Pritunl Azure SSO to Microsoft Graph API #484
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Pritunl developers,
Azure AD Graph API is deprecated. Pritunl has to be switched to use Microsoft Graph API.
Previously, Pritunl required Directory.Read.All API permission, which was excessive and potentially vulnerable. It might be also a problem when working with big AD sets. I have introduced the new API url, fixed all request params and changed the logic of getting user groups to match new Microsoft Graph API.
Thank you in advance,
Szymon