Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleStepSelectorBuilder case when there is only one step #95

Open
leolara opened this issue Aug 23, 2023 · 2 comments · May be fixed by #134
Open

SimpleStepSelectorBuilder case when there is only one step #95

leolara opened this issue Aug 23, 2023 · 2 comments · May be fixed by #134
Assignees
Labels
gfi intermediate Intermediate good first issue good first issue Good for newcomers

Comments

@leolara
Copy link
Collaborator

leolara commented Aug 23, 2023

The SimpleStepSelectorBuilder creates a column for each step type, that gets to be 1 in the row where a step instance of that type starts.

When there is only one step type we don't need any column, because all steps are of this step type.

Make SimpleStepSelectorBuilder to don't add any columns where there is a column, and create a StepSelector that works without any column.

@leolara leolara added good first issue Good for newcomers gfi intermediate Intermediate good first issue labels Aug 23, 2023
@000wan
Copy link
Contributor

000wan commented Sep 11, 2023

Hi, may I work on this issue?

@leolara
Copy link
Collaborator Author

leolara commented Sep 13, 2023

assigned @000wan

@000wan 000wan linked a pull request Sep 18, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gfi intermediate Intermediate good first issue good first issue Good for newcomers
Projects
Status: In review
Development

Successfully merging a pull request may close this issue.

2 participants