Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MaxWidthCellManager work with shared signals #96

Open
leolara opened this issue Aug 23, 2023 · 4 comments
Open

Make MaxWidthCellManager work with shared signals #96

leolara opened this issue Aug 23, 2023 · 4 comments
Assignees
Labels
gfi intermediate Intermediate good first issue good first issue Good for newcomers

Comments

@leolara
Copy link
Collaborator

leolara commented Aug 23, 2023

Currently MaxWidthCellManager does not work with shared signals (SingleRowCellManager does).

Make them work.

What is a shared signal?

A shared signal is a signal that is shared by all the steps, and you can do rotation arbitrarily between all the steps, but they only work when the circuit has all the steps with the same height. Forward signals are also shared between steps, but you can only do a rotation to the next step, however they work on circuits with steps of different height.

@leolara leolara added good first issue Good for newcomers gfi intermediate Intermediate good first issue labels Aug 23, 2023
@e3243eric
Copy link

I would like to take this on. I've looked into SingleRowCellManager and MaxWidthCellManager. Is there a difference between them, where SingleRowCellManager only has one fixed height, while MaxWidthCellManager allows for multiple heights with a maximum size?

@leolara
Copy link
Collaborator Author

leolara commented Sep 19, 2023

Yes, that is the difference

@leolara
Copy link
Collaborator Author

leolara commented Sep 19, 2023

@e3243eric assigned

@rutefig
Copy link
Contributor

rutefig commented Nov 4, 2023

@e3243eric are you working on this? Otherwise can I take it?
@leolara can I take this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gfi intermediate Intermediate good first issue good first issue Good for newcomers
Projects
Status: In review
Development

No branches or pull requests

3 participants