Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐳 Use multi stage build for query api docker image #146

Merged
merged 4 commits into from
May 8, 2023
Merged

🐳 Use multi stage build for query api docker image #146

merged 4 commits into from
May 8, 2023

Conversation

sripwoud
Copy link
Collaborator

@sripwoud sripwoud commented May 8, 2023 •
edited
Loading

Description

Get rid of docker compose files (it is a pain to manage the secrets with the secret entrypoints scripts).
Optimize docker build: use multi stage builds

  • I have performed a self-review of my code.
  • All existing CI checks pass
    • My code compiles
    • My code follows the style guidelines of this project (code is linted and formatted)
    • My code doesn't break existing tests
  • I have added tests that prove my fix is effective or that my feature works.
  • I added a reviewer for this pull request.
  • I have assigned myself to this pull request.
  • I have added the appropriate label(s) to this pull request.

@coveralls
Copy link
Collaborator

coveralls commented May 8, 2023 •
edited
Loading

Coverage Status

Coverage: 80.69%. Remained the same when pulling edf4f6b on docker-query into 40a2b83 on staging.

@sripwoud sripwoud changed the base branch from main to staging May 8, 2023 14:52
@sripwoud sripwoud changed the base branch from staging to main May 8, 2023 14:52
@sripwoud sripwoud changed the base branch from main to staging May 8, 2023 14:54
@sripwoud sripwoud self-assigned this May 8, 2023
@sripwoud sripwoud merged commit ec8ad16 into staging May 8, 2023
3 checks passed
@sripwoud sripwoud deleted the docker-query branch May 8, 2023 15:09
@sripwoud sripwoud mentioned this pull request May 9, 2023
Merged
sripwoud added a commit that referenced this pull request May 9, 2023
@sripwoud
🐳♻️➖ Remove dune-ts, use multi stages docker build for query api (#148
79caccc 
)

* ♻️➖ Use dune api key instead of custom `dune-ts` lib (#145)

* refactor: use cowprotocol dune client

* fix: need to use extra quotes around eth address query param

* test dune ts query

* fix test gh action

Need to set `DUNE_API_KEY` env var

* 🐳 Use multi stage build for query api docker image (#146)

* 🐳 Use multi stage build for query api docker image

* format/lint

* rename fly apps

* remove node/pnpm install steps from gh deploy action

* fix deploy step

* update fly config files

* chore: gitignore lock file

* update dockerignore

* fix deploy gh action

* update path triggers

* update prove api Dockerfile

* update query api Dockerfile

* refactor/fix query-api Dockerfile

* update staging deployment config

* update prod deployment config

* update READMEs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sripwoud sripwoud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sripwoud @coveralls