Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hitting import issues on x86_64-unknown-linux-gnu from maybe_rayon crate #116

Closed
ankur2136 opened this issue Dec 21, 2023 · 4 comments
Closed

Comments

@ankur2136
Copy link

Error log.

error[E0432]: unresolved imports `maybe_rayon::current_num_threads`, `maybe_rayon::iter::IndexedParallelIterator`, `maybe_rayon::iter::IntoParallelRefIterator`, `maybe_rayon::slice::ParallelSliceMut`
Error:   --> packages/halo2curves/src/multicore.rs:8:5
   |
8  |     current_num_threads,
   |     ^^^^^^^^^^^^^^^^^^^ no `current_num_threads` in the root
9  |     iter::{IndexedParallelIterator, IntoParallelRefIterator},
   |            ^^^^^^^^^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^^^^^^^ no `IntoParallelRefIterator` in `iter`
   |            |
   |            no `IndexedParallelIterator` in `iter`
10 |     slice::ParallelSliceMut,
   |     ^^^^^^^^^^^^^^^^^^^^^^^ no `ParallelSliceMut` in `slice`
   |
help: a similar name exists in the module
   |
9  |     iter::{IntoParallelIterator, IntoParallelRefIterator},
   |            ~~~~~~~~~~~~~~~~~~~~
help: a similar name exists in the module
   |
9  |     iter::{IndexedParallelIterator, IntoParallelIterator},
   |                                     ~~~~~~~~~~~~~~~~~~~~
help: a similar name exists in the module
   |
10 |     slice::ParallelSlice,
   |            ~~~~~~~~~~~~~

For more information about this error, try `rustc --explain E0432`.
error: could not compile `halo2curves` (lib) due to previous error
Error: warning: build failed, waiting for other jobs to finish...
Error: Compiling your crate to WebAssembly failed
Caused by: Compiling your crate to WebAssembly failed
Caused by: failed to execute `cargo build`: exited with exit status: 101
  full command: cd "/home/runner/work/spartan-ecdsa-experiment/packages/spartan_wasm" && "cargo" "build" "--lib" "--release" "--target" "wasm32-unknown-unknown"

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

@huitseeker
Copy link
Contributor

Try loading the crate excluding the default multicore feature (default-features = false in your dep).

@ankur2136
Copy link
Author

@CPerezz
Copy link
Member

CPerezz commented Jan 4, 2024

How about something like this https://github.com/privacy-scaling-explorations/halo2curves/pull/117/files

Sorry, I completelly missed this.
I like the proposal more than what we have. Let me ping the teammates!

@duguorong009
Copy link
Contributor

duguorong009 commented Jan 10, 2024

@CPerezz
I think we can close this issue, since multicore module is gone(maybe_rayon is replaced by rayon) in PR #122.
What do you think? sir
cc @ankur2136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants