Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[contracts] [circuits] Implement a QuinTree #101

Closed
weijiekoh opened this issue May 8, 2020 · 0 comments · Fixed by #107
Closed

[contracts] [circuits] Implement a QuinTree #101

weijiekoh opened this issue May 8, 2020 · 0 comments · Fixed by #107
Assignees
@weijiekoh
Labels
enhancement New feature or request
Projects
Minimum Viable MACI

Comments

@weijiekoh
Copy link
Contributor

weijiekoh commented May 8, 2020 •
edited

A quintree is ideal for Poseidon-based Merkle tree accumulators. But this will take a lot of work to implement.

Started work here: https://github.com/weijiekoh/maci/tree/feat/quadtree

Also see https://github.com/Loopring/protocols/blob/master/packages/loopring_v3/contracts/impl/libexchange/ExchangeBalances.sol#L95 for an example of a quadtree impl.
@weijiekoh weijiekoh created this issue from a note in Minimum Viable MACI (Backlog) May 8, 2020
@weijiekoh weijiekoh moved this from Backlog to Sprint 6 in Minimum Viable MACI May 12, 2020
@weijiekoh weijiekoh mentioned this issue May 12, 2020
Closed
@weijiekoh weijiekoh changed the title [contracts] [circuits] Consider a QuadTree [contracts] [circuits] Implement a QuadTree May 12, 2020
@weijiekoh weijiekoh added the enhancement New feature or request label May 14, 2020
@weijiekoh weijiekoh self-assigned this May 14, 2020
@weijiekoh weijiekoh moved this from Sprint 6 to In progress in Minimum Viable MACI May 15, 2020
@weijiekoh weijiekoh moved this from In progress to Needs review in Minimum Viable MACI May 21, 2020
@weijiekoh weijiekoh changed the title [contracts] [circuits] Implement a QuadTree [contracts] [circuits] Implement a QuinTree May 23, 2020
@weijiekoh weijiekoh linked a pull request May 23, 2020 that will close this issue
5 leaves per node for the vote option tree #107
Merged
@weijiekoh weijiekoh moved this from Needs review to Done in Minimum Viable MACI Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weijiekoh weijiekoh

Labels
enhancement New feature or request
Projects
No open projects
Minimum Viable MACI
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

5 leaves per node for the vote option tree weijiekoh/maci
1 participant
@weijiekoh