Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[contract] use a nothing-up-my-sleeve zero value for the Merkle tree contract #35

Closed
weijiekoh opened this issue Jan 3, 2020 · 3 comments
Assignees

Comments

@weijiekoh
Copy link
Contributor

No description provided.

@weijiekoh weijiekoh created this issue from a note in Minimum Viable MACI (Sprint 1 (roughly 6-19 Jan)) Jan 3, 2020
@barryWhiteHat
Copy link
Collaborator

I'm not sure we should use a nothing up my sleave value for merkle tree. Because originally everything in the merkle tree needs to be known. So we should initalize it to be an empty tree. Or am i missing something?

@weijiekoh
Copy link
Contributor Author

I think when I proposed this, I was thinking along the lines that we should use the audited Merkle Tree code from Semaphore instead. And that uses a nothing-up-my-sleeve value. Perhaps this issue should be renamed to "Use the audited Merkle Tree contract from Semaphore" instead.

@barryWhiteHat
Copy link
Collaborator

OH yeah you are right. As long as the ntohing up my sleve value i known this is the same as using zeroed leaves. In fact its better because we can make a trust argument about it.

@kendricktan kendricktan moved this from Sprint 1 (roughly 6-19 Jan) to In progress in Minimum Viable MACI Jan 11, 2020
@weijiekoh weijiekoh moved this from In progress to Needs review in Minimum Viable MACI Jan 11, 2020
@weijiekoh weijiekoh moved this from Needs review to Done in Minimum Viable MACI Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

3 participants