fix: listen to user doc changes instead of fetching doc to check if exists #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng doc to check if exists There can be some lag after running the auth command before the user can be found in firebase. In which case trying to fetch the user will fail with `FirebaseError: Unable to retrieve the authenticated user.`. Instead we can listen and wait for user doc changes. privacy-scaling-explorations#220
sripwoud
changed the title
ctrlc03
requested changes
Nov 2, 2023
| @@ -123,6 +124,26 @@ export const getDocumentById = async ( | |||
| return getDoc(docRef) | |||
| } | |||
|
|
|||
| export const waitForUserDocumentToExist = (firestoreDatabase: Firestore, collection: string, documentId: string) => { | |||
There was a problem hiding this comment.
while this would be a great solution, the code might hang forever if a user tried to auth and they did not pass the sybil checks. As discussed, a fetch and retry mechanism might work better for now until we find a more elegant solution
| @@ -150,6 +158,29 @@ describe("Database", () => { | |||
| }) | |||
| }) | |||
|
|
|||
| describe("waitForUserDocumentToExist", () => { | |||
There was a problem hiding this comment.
great stuff adding a test for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Open a PR for p0tion
Description
See https://discord.com/channels/943612659163602974/1166371125450768495/1167435859755278357
It looks like in case of a lag between the
authcommand and thecontributecommand, the user document may not yet exist in firebase.As a solution we can listen for document changes and wait for the document to
exists().Fixes #220
How Has This Been Tested?
waitForUserDocumentToExistMy unit test is a bit artificial so I am 100% my fix works as expected, I'd like to run additional manual e2e testing, but I am not sure how...
Checklist:
This PR deliberately doesn't follow style guidelines to avoid big diff, I suggest merging chore: format, lint #225 first then rebase