Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "queue" bug #249

Closed
SebastianZimmeck opened this issue Jul 23, 2021 · 4 comments
Closed

Fix "queue" bug #249

SebastianZimmeck opened this issue Jul 23, 2021 · 4 comments
Assignees
Labels
bug Something isn't working
Projects

Comments

@SebastianZimmeck
Copy link
Member

There seems to be a bug with the queue. I just pulled the latest version and ran it. The balls just keep spinning. Not sure why that is. If you have time, maybe you can look into it @danielgoldelman (of course, everyone else feel free to chime in as well).

Screen Shot 2021-07-22 at 8 24 32 PM

Screen Shot 2021-07-22 at 8 23 47 PM

@SebastianZimmeck SebastianZimmeck added the bug Something isn't working label Jul 23, 2021
@SebastianZimmeck SebastianZimmeck added this to To do in Daniel via automation Jul 23, 2021
@notowen333
Copy link
Collaborator

@SebastianZimmeck did you npm install after pulling main? The extension complies and runs on my machine.

@SebastianZimmeck
Copy link
Member Author

SebastianZimmeck commented Jul 23, 2021

Great! Thanks, @notowen333! That fixed it! So, apparently, my npm version was outdated and I needed to update it?

@SebastianZimmeck SebastianZimmeck removed this from To do in Daniel Jul 23, 2021
@SebastianZimmeck SebastianZimmeck added this to To do in Owen via automation Jul 23, 2021
@SebastianZimmeck SebastianZimmeck moved this from To do to Long Term Done in Owen Jul 23, 2021
Owen automation moved this from Long Term Done to Short Term Done Jul 23, 2021
@notowen333
Copy link
Collaborator

notowen333 commented Jul 23, 2021

Great! Thanks, @notowen333! That fixed it! So, apparently, my npm version was outdated and I needed to update it?

During development, every time a dependency is added to the project, you have to re-run npm install so the node_modules folder on your machine has the packages that are used by our extension.

When we build the project for production with npm run build our code and necessary modules will be bundled by webpack into one folder called dist

Screen Shot 2021-07-23 at 11 28 31 AM

So the code for queue that you were missing in development would be in the bundle.background.js file in production.

If you zip all the files in this folder and then load it into firefox, the extension works! Just tried it. Thank David for setting all of this up 😄

@SebastianZimmeck
Copy link
Member Author

Great explanation, @notowen333! Added a link to it in our readme.

@notowen333 notowen333 moved this from Short Term Done to Long Term Done in Owen Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Owen
Long Term Done
Development

No branches or pull requests

3 participants