Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update primary button text #1095

Merged
merged 1 commit into from
Apr 24, 2022
Merged

Update primary button text #1095

merged 1 commit into from
Apr 24, 2022

Conversation

jonaharagon
Copy link
Member

@jonaharagon jonaharagon commented Apr 23, 2022

Resolves: #1094

Preview: #1095 (comment)

@jonaharagon jonaharagon added the c:enhancements new features or other enhancements to the website itself label Apr 23, 2022
@netlify

This comment was marked as outdated.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having "Repository" instead of "Source Code" would be better.

The latter might sound too technical/irrelevant for some people, thus discouraging them from clicking the link. More often than not, repositories house important non-code related information such as wikis and a faq, with the readme sometimes even serving as the project's homepage.

@jonaharagon
Copy link
Member Author

@lx-is I actually figured the opposite, "repository" is dev-speak, while more people are probably familiar with the idea of "source code".

I wonder if we should change the links to the project's README specifically if they are only on a Git repo, and say "View README" or "View Info" instead.

@ghost
Copy link

ghost commented Apr 24, 2022

Huh, interesting. I thought repository was a pretty mainstream term nowadays.

I just feel "source code" implies only the raw code, meant for auditing and such. Maybe just me.

I think "___ Info" could work, with the blank being replaced with project, product, software, or whatever.

@elitejake
Copy link
Contributor

Or the button text should say Visit Homepage instead of Source Code. Because it is technically the project's home page.


If we are sticking to Source Code, I'd say View Source would be better,

dngray pushed a commit that referenced this pull request Apr 24, 2022
@dngray dngray marked this pull request as ready for review April 24, 2022 16:14
@dngray
Copy link
Member

dngray commented Apr 24, 2022

I've gone ahead and changed the others, merge when you want @jonaharagon

@elitejake
Copy link
Contributor

@dngray what's the difference between Visit Website and Visit Homepage?

@ghost
Copy link

ghost commented Apr 24, 2022

Should "Visit" even be used at all? Having a verb isn't consistent with the other buttons

@dngray
Copy link
Member

dngray commented Apr 24, 2022

@dngray what's the difference between Visit Website and Visit Homepage?

I used Homepage when the product was a project site, I used Website, when it was a service

@cloudflare-pages
Copy link

cloudflare-pages bot commented Apr 24, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9c0f39f
Status:⚡️  Build in progress...

View logs

Co-Authored-By: Daniel Nathan Gray <dng@disroot.org>
@jonaharagon jonaharagon merged commit 9c0f39f into main Apr 24, 2022
@jonaharagon jonaharagon deleted the pr-buttons branch April 24, 2022 20:20
dngray added a commit to elitejake/privacyguides.org that referenced this pull request Apr 25, 2022
Co-Authored-By: Daniel Nathan Gray <dng@disroot.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:enhancements new features or other enhancements to the website itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace the "Visit website.example" buttons with "Visit Homepage" or "Visit Repository"
3 participants