Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make headings consistent and remove redundant descriptions #1207

Merged
merged 3 commits into from
May 12, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 12, 2022

The title and subtitle are redundant here. Also the blurb about browsing the "dark net" is unnecessary as the title is self-explanatory.

@ghost ghost temporarily deployed to preview May 12, 2022 20:22 Inactive
@ghost ghost changed the title Remove redundant text Remove redundant text on the self-cotained networks page May 12, 2022
@github-actions
Copy link

github-actions bot commented May 12, 2022

🎊 PR Preview 8ea5f36 has been successfully built and deployed to https://privacyguides-privacyguides-org-preview-pr-1207.surge.sh

🕐 Build time: 92.256s

🤖 By surge-preview

@ghost ghost requested a review from dngray May 12, 2022 20:29
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change each network's heading to h2 instead of h3

wait nvm, that wouldn't be consistent with other pages

@blacklight447
Copy link
Member

blacklight447 commented May 12, 2022

Are we sure we don't just wanna replace it rather then just remove? It seems rather empty without it, and it wouldn't be consistent with the rest of the site which provides small descriptions at the top of the page.

@ghost
Copy link
Author

ghost commented May 12, 2022

Are we sure we don't just wanna replace it rather then just remove? It seems rather emoty without it, and it wouldn't be consistent with the rest of the site which provides small describtions at the top of the page.

Sure, what do you think should go there? Maybe something like "These networks aren't accessible through a normal browser; you need specific software to use them."

@ghost ghost temporarily deployed to preview May 12, 2022 22:14 Inactive
Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait nvm, that wouldn't be consistent with other pages

probably an indication the other pages should be changed.

@jonaharagon jonaharagon self-assigned this May 12, 2022
@jonaharagon jonaharagon temporarily deployed to preview May 12, 2022 22:53 Inactive
@jonaharagon jonaharagon changed the title Remove redundant text on the self-cotained networks page Make headings consistent and remove redundant descriptions May 12, 2022
@jonaharagon jonaharagon merged commit c0edc33 into main May 12, 2022
@jonaharagon jonaharagon deleted the pr-self-contained-network-fix branch May 12, 2022 23:00
@dngray dngray added the t:correction content corrections or errors label May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:correction content corrections or errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants