Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Attention" to "Warning" in Warning Box Message #1242

Merged
4 commits merged into from
May 15, 2022
Merged

Change "Attention" to "Warning" in Warning Box Message #1242

4 commits merged into from
May 15, 2022

Conversation

d4rklynk
Copy link
Contributor

@d4rklynk d4rklynk commented May 15, 2022

You wrote "warning" on other Warning Boxes AFAIK, I think it would be better to stick to it.
It's confusing to have too many terms to explain a danger IMO

@d4rklynk d4rklynk temporarily deployed to preview May 15, 2022 23:31 Inactive
@github-actions
Copy link

github-actions bot commented May 15, 2022

🎊 PR Preview 34be30c has been successfully built and deployed to https://privacyguides-privacyguides-org-preview-pr-1242.surge.sh

🕐 Build time: 90.025s

🤖 By surge-preview

@d4rklynk d4rklynk temporarily deployed to preview May 15, 2022 23:33 Inactive
@d4rklynk d4rklynk temporarily deployed to preview May 15, 2022 23:38 Inactive
@d4rklynk d4rklynk temporarily deployed to preview May 15, 2022 23:40 Inactive
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think that's better

@ghost ghost merged commit ba1817d into privacyguides:main May 15, 2022
@dngray dngray added the t:correction content corrections or errors label May 16, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:correction content corrections or errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants