Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update recommendation card design #1316

Merged
merged 1 commit into from May 28, 2022
Merged

Update recommendation card design #1316

merged 1 commit into from May 28, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 25, 2022

Updated the button design for the recommendation cards to allow room for more icons, such as donation buttons as requested in #1241.

I'm also fixing little issues I find along the way.

To do:

  • Web Browsers
  • Android
  • Linux
  • Qubes OS
  • Router Firmware
  • Cloud Storage
  • DNS Resolvers
  • Email Services
  • Search Engines
  • VPN Services
  • Calendar and Contact Sync
  • Notebooks
  • Email Clients
  • Encryption Software
  • File Sharing and Sync
  • Metadata Removal Tools
  • Multi-Factor Authenticators
  • Password Managers
  • Productivity Tools
  • Real-Time Communication
  • News Aggregators
  • Self-Contained Networks
  • Video Streaming

@ghost ghost temporarily deployed to preview May 25, 2022 03:12 Inactive
@github-actions
Copy link

github-actions bot commented May 25, 2022

🎊 PR Preview 0ef7b40 has been successfully built and deployed to https://privacyguides-privacyguides-org-preview-pr-1316.surge.sh

🕐 Build time: 101.991s

🤖 By surge-preview

@ghost ghost temporarily deployed to preview May 25, 2022 04:01 Inactive
@ghost ghost temporarily deployed to preview May 25, 2022 04:23 Inactive
@ghost ghost temporarily deployed to preview May 25, 2022 04:29 Inactive
@ghost ghost temporarily deployed to preview May 25, 2022 04:38 Inactive
@ghost ghost temporarily deployed to preview May 25, 2022 04:59 Inactive
@ghost ghost temporarily deployed to preview May 25, 2022 05:11 Inactive
@ghost ghost temporarily deployed to preview May 25, 2022 05:27 Inactive
@ghost ghost temporarily deployed to preview May 25, 2022 05:40 Inactive
@ghost ghost temporarily deployed to preview May 25, 2022 05:50 Inactive
@ghost ghost temporarily deployed to preview May 25, 2022 06:27 Inactive
@d4rklynk
Copy link
Contributor

Do you think we could add pricing ? For email, cloud providers for example

@dngray dngray force-pushed the main branch 3 times, most recently from d2cd7a7 to f335a7e Compare May 25, 2022 14:15
@jonaharagon jonaharagon added the c:enhancements new features or other enhancements to the website itself label May 25, 2022
@ghost ghost temporarily deployed to preview May 25, 2022 18:34 Inactive
@jonaharagon jonaharagon linked an issue May 25, 2022 that may be closed by this pull request
@ghost ghost temporarily deployed to preview May 25, 2022 18:40 Inactive
@ghost ghost temporarily deployed to preview May 25, 2022 18:58 Inactive
@ghost ghost added t:bug website bugs or errors t:correction content corrections or errors and removed t:bug website bugs or errors labels May 25, 2022
@ghost ghost temporarily deployed to preview May 25, 2022 19:23 Inactive
@ghost ghost temporarily deployed to preview May 25, 2022 19:57 Inactive
@ghost ghost self-assigned this May 25, 2022
@ghost ghost temporarily deployed to preview May 25, 2022 20:14 Inactive
@ghost ghost temporarily deployed to preview May 25, 2022 21:11 Inactive
@ghost ghost temporarily deployed to preview May 25, 2022 21:21 Inactive
@ghost ghost temporarily deployed to preview May 26, 2022 01:46 Inactive
@ghost ghost temporarily deployed to preview May 26, 2022 01:49 Inactive
@ghost ghost temporarily deployed to preview May 26, 2022 02:02 Inactive
@ghost ghost temporarily deployed to preview May 26, 2022 02:07 Inactive
@ghost ghost temporarily deployed to preview May 26, 2022 02:17 Inactive
@ghost ghost temporarily deployed to preview May 26, 2022 02:29 Inactive
@ghost ghost temporarily deployed to preview May 26, 2022 02:51 Inactive
@ghost ghost temporarily deployed to preview May 26, 2022 03:03 Inactive
Copy link
Member

@blacklight447 blacklight447 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man, this was a pain in the ass to review, so many link to click and check. Anyhow, all seems to be in order, great job Lexi!

@ghost ghost temporarily deployed to preview May 26, 2022 18:02 Inactive
@ghost ghost temporarily deployed to preview May 27, 2022 05:33 Inactive
@ghost ghost temporarily deployed to preview May 27, 2022 05:42 Inactive
@ghost ghost temporarily deployed to preview May 27, 2022 17:25 Inactive
@ghost ghost temporarily deployed to preview May 28, 2022 02:06 Inactive
@dngray dngray temporarily deployed to preview May 28, 2022 04:50 Inactive
@dngray dngray temporarily deployed to preview May 28, 2022 04:52 Inactive
@ghost ghost temporarily deployed to preview May 28, 2022 04:57 Inactive
@ghost ghost temporarily deployed to preview May 28, 2022 05:13 Inactive
@ghost ghost temporarily deployed to preview May 28, 2022 05:17 Inactive
@dngray dngray temporarily deployed to preview May 28, 2022 05:29 Inactive
Signed-off-by: Daniel Gray <dng@disroot.org>
@dngray dngray temporarily deployed to preview May 28, 2022 05:39 Inactive
@dngray dngray merged commit 0ef7b40 into privacyguides:main May 28, 2022
@ghost ghost deleted the button-redesign branch May 28, 2022 05:41
@dngray dngray temporarily deployed to production May 28, 2022 05:54 Inactive
dngray pushed a commit that referenced this pull request May 28, 2022
Signed-off-by: Daniel Gray <dng@disroot.org>
dngray pushed a commit that referenced this pull request May 28, 2022
Signed-off-by: Daniel Gray <dng@disroot.org>
dngray pushed a commit that referenced this pull request May 28, 2022
Signed-off-by: Daniel Gray <dng@disroot.org>
dngray pushed a commit that referenced this pull request May 28, 2022
Signed-off-by: Daniel Gray <dng@disroot.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:enhancements new features or other enhancements to the website itself t:correction content corrections or errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Donation Link for Non-Commercial Recommendations
4 participants