Add grid layout for download links #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview 819ee87 has been successfully built and deployed to https://privacyguides-privacyguides-org-preview-pr-1372.surge.sh 🕐 Build time: 117.031s
🤖 By surge-preview |
ghost
previously requested changes
Jun 1, 2022
There was a problem hiding this comment.
Couple things
- The font should be made smaller (maybe 1em). Currently it is bigger than the download title itself.
- A solution should be found for the annotations that are occasionally used in the downloads menu to give additional context. Example in the Brave card: it is giving additional context to the Linux download, but with this it's separated quite far apart from it https://privacyguides-privacyguides-org-preview-pr-1372.surge.sh/browsers/#brave The annotation box also gets separated from the + icon
|
Both of those issues are now fixed, but all the download admonitions need to be converted to unordered lists (see the changes made to |
jonaharagon
approved these changes
Jun 1, 2022
jonaharagon
added
the
c:enhancements
ghost
changed the title
ghost
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseeds: #1349
Updated download links
Resolves: #
{.card-link}from all download links