Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Search Engine page #1405

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Update Search Engine page #1405

merged 1 commit into from
Jun 8, 2022

Conversation

TommyTran732
Copy link
Contributor

DDG > Brave > SearcXNG > Startpage.

The reasoning for this is literally already listed for most of them. DDG supports no JS mode, making it the best of the bunch. Brave has anonymous analytics enabled by default so it's worse than DDG.

The only thing that's not mentioned is that StartPage sometimes block VPN or Tor IPs, so it is not as friendly and therefore is put at the bottom. This PR added that.

@TommyTran732 TommyTran732 temporarily deployed to preview June 7, 2022 07:51 Inactive
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

🎊 PR Preview 648dda1 has been successfully built and deployed to https://privacyguides-privacyguides-org-preview-pr-1405.surge.sh

🕐 Build time: 132.726s

🤖 By surge-preview

@TommyTran732 TommyTran732 temporarily deployed to preview June 7, 2022 07:54 Inactive
@dngray
Copy link
Member

dngray commented Jun 7, 2022

Also DDG and Brave Search both offer .onion, which is something we favor, but DDG does have a HTML only view so that i guess puts it just above.

@dngray dngray added c:browsers browsers, add-ons, and related topics t:correction content corrections or errors labels Jun 7, 2022
ghost
ghost previously requested changes Jun 7, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look at the preview lol. the page is all messed up

duckduckgo is on there twice and the startpage card is improperly formatted

docs/search-engines.en.md Outdated Show resolved Hide resolved
@ghost ghost added c:providers service providers and similar centralized/federated services and removed c:browsers browsers, add-ons, and related topics labels Jun 7, 2022
@ghost ghost changed the title Fix Search Engine Ordering Update Search Engine page ordering Jun 7, 2022
@dngray dngray temporarily deployed to preview June 8, 2022 05:40 Inactive
dngray
dngray previously requested changes Jun 8, 2022
docs/search-engines.en.md Show resolved Hide resolved
@dngray dngray temporarily deployed to preview June 8, 2022 05:43 Inactive
@ghost ghost temporarily deployed to preview June 8, 2022 05:49 Inactive
@ghost ghost temporarily deployed to preview June 8, 2022 06:00 Inactive
@ghost ghost dismissed stale reviews from dngray and themself June 8, 2022 06:02

fixed

@dngray dngray temporarily deployed to preview June 8, 2022 06:49 Inactive
@ghost ghost changed the title Update Search Engine page ordering Update Search Engine page Jun 8, 2022
@ghost ghost temporarily deployed to preview June 8, 2022 06:52 Inactive
@dngray dngray temporarily deployed to preview June 8, 2022 06:55 Inactive
@dngray dngray temporarily deployed to preview June 8, 2022 07:05 Inactive
Signed-off-by: Daniel Gray <dng@disroot.org>
Signed-off-by: lexi <git@27lx.me>
@dngray dngray force-pushed the fix-search-engine-ordering branch from 648dda1 to f63969c Compare June 8, 2022 07:06
@dngray dngray merged commit f63969c into main Jun 8, 2022
@dngray dngray deleted the fix-search-engine-ordering branch June 8, 2022 07:07
@hook9
Copy link
Member

hook9 commented Jun 8, 2022

I honestly think what DuckDuckGo saves is worse than Brave's usage metrics.

DuckDuckGo:

We also save searches, but again, not in a personally identifiable way, as we do not store IP addresses or unique User agent strings. We use aggregate, non-personal search data to improve things like misspellings.

Brave:

Number of daily/weekly/monthly visits
Number of returning visits
Number of search queries per day
How long you’ve been using Brave Search
Average query length
How many users have chosen to leave feedback about Brave Search
The operating systems people use when they visit (e.g. macOS, Windows, etc)
The browser you’ve visited from (e.g. Brave, Chrome, Safari, etc)

For search queries that only works for some queries, and it can get really murky, for example if the search query contains personal information or anything that can tie it back to the user.

@ghost
Copy link

ghost commented Jun 8, 2022

I honestly think what DuckDuckGo saves is worse than Brave's usage metrics.

I do agree with this.

@dngray
Copy link
Member

dngray commented Jun 8, 2022

Oh, damn I didn't see this before I merged.

Hmm, I think with Brave/DDG though it might be pretty close because they both have .onion, Brave Search does have anonymous usage metrics that you have to disable.

@ghost
Copy link

ghost commented Jun 8, 2022

Brave Search does have anonymous usage metrics that you have to disable.

The usage metrics are still better, I'd argue, than saving every search. And at least the usage metrics can be disabled, whereas Duck's search logs are mandatory.

@dngray
Copy link
Member

dngray commented Jun 8, 2022

Point taken, I put in a PR #1405.

Opt out is better than no opt out.

dngray pushed a commit that referenced this pull request Jun 9, 2022
Signed-off-by: Daniel Gray <dng@disroot.org>
Signed-off-by: lexi <git@27lx.me>
@evil-user
Copy link

evil-user commented Jun 19, 2022

Heard duckduckgo favors microsoft's trackers, https://www.theregister.com/2022/06/17/brave_duckduckgo/

This is bad for privacy we should favor brave search over duckduckgo. Also duckduckgo does censorship and downranks content which it feels is russian propaganda.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:providers service providers and similar centralized/federated services t:correction content corrections or errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants