-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust Vaultwarden and Molly Listings #1669
Conversation
🎊 PR Preview bc9854e has been successfully built and deployed to https://privacyguides-privacyguides-org-preview-pr-1669.surge.sh 🕐 Build time: 176.502s 🤖 By surge-preview |
I feel like this PR is a bit inconsistent. If we feel like having the logos for projects like Molly and Vaultwarden isn't a format we like, I can understand that. However, we now have one format for Vaultwarden, a different for Molly (in the form of an actual recommendation card in the main page instead of as part of the Signal guide) and yet we've removed it from the Tools page? If a project has a proper recommendation card, it makes sense for it to be listed in /tools. The reason why I merely mentioned Molly in the main page and went into detail in the Signal hardening page is because I thought that it not being available on iOS would be a blocker, and that it is currently just a fork of Signal with a few additional (albeit great) features. I would have wanted us to list Molly in the main page in full glory once their planned Molly server comes out, which would differentiate it from Signal in a significant manner. |
2a64f35
to
bc9854e
Compare
I realized I didn't know what to do, because actually software configuration and recommendations shouldn't be in the Knowledge Base section at all, all of that information would ideally be on the RTC page under Recommendations, similar to how we have configuration recommendations for browsers on the browser pages. But I also see why it was done this way, since there's a significant amount of information... I made this PR more consistent so it should be good for now, and overall look better, but I want to think about how the Signal Configuration page is arranged and maybe rearrange things in the future... |
I think the PR makes a lot more sense right now, although I'm not quite sure about removing every mention of Molly in the RTC page. What was your thought process behind that? |
I just don't want to have a recommendation like Molly on that page (or the tools page) without all the accompanying information that's on the hardening page (especially since it's Android only anyways). |
Thanks for taking this up, it looked so off and unclear. This PR makes a lot of sense. Putting Molly in an advanced guide is probably also for the better. Keeping it simple for the average user and still providing all information for people who want/need to go a step further. |
This comment was marked as off-topic.
This comment was marked as off-topic.
bc9854e
to
a781629
Compare
Resolves: #1564