Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iOS Guide #1750

Merged
merged 1 commit into from
Oct 22, 2022
Merged

Add iOS Guide #1750

merged 1 commit into from
Oct 22, 2022

Conversation

ghost
Copy link

@ghost ghost commented Sep 11, 2022

Add iOS #697

@ghost ghost changed the title Pr ios Add iOS Guide Sep 11, 2022
@ghost ghost self-assigned this Sep 11, 2022
@ghost ghost added the c:guides full-length guides and content label Sep 11, 2022
@dngray dngray temporarily deployed to preview September 12, 2022 16:27 Inactive
@github-actions
Copy link

github-actions bot commented Sep 12, 2022

🎊 PR Preview 730284d has been successfully built and deployed to https://privacyguides-privacyguides-org-preview-pr-1750.surge.sh

🕐 Build time: 72.77s

🤖 By surge-preview

@ghost ghost temporarily deployed to preview September 13, 2022 14:59 Inactive
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
@ghost ghost temporarily deployed to preview September 19, 2022 13:43 Inactive
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
@ghost ghost temporarily deployed to preview September 23, 2022 15:04 Inactive
@ghost ghost temporarily deployed to preview October 12, 2022 05:54 Inactive
@ghost ghost temporarily deployed to preview October 12, 2022 06:04 Inactive
@ghost ghost temporarily deployed to preview October 12, 2022 06:56 Inactive
@ghost ghost temporarily deployed to preview October 12, 2022 07:08 Inactive
@ghost ghost temporarily deployed to preview October 12, 2022 07:25 Inactive
@ghost ghost temporarily deployed to preview October 12, 2022 07:33 Inactive
@ghost ghost temporarily deployed to preview October 12, 2022 07:36 Inactive
@ghost ghost temporarily deployed to preview October 12, 2022 07:53 Inactive
@ghost ghost temporarily deployed to preview October 12, 2022 23:55 Inactive
@ghost ghost marked this pull request as ready for review October 12, 2022 23:56
@ghost ghost temporarily deployed to preview October 13, 2022 00:24 Inactive
@ghost ghost temporarily deployed to preview October 16, 2022 03:44 Inactive
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
@ghost ghost temporarily deployed to preview October 16, 2022 08:01 Inactive
Copy link
Contributor

@KaiTebay KaiTebay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great so far! I've suggested some very minor changes (fixing a few sentences and preferring contractions, etc.)

I'm only halfway though: I'll continue later today, when I have time! 😄

docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Show resolved Hide resolved
docs/ios/configuration.en.md Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Show resolved Hide resolved
docs/ios/configuration.en.md Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
@ghost ghost temporarily deployed to preview October 17, 2022 01:49 Inactive
Copy link
Contributor

@KaiTebay KaiTebay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested a few minor grammatical and stylistic changes, but this looks great to me. I'm excited for its release!

docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
@ghost ghost temporarily deployed to preview October 20, 2022 12:21 Inactive
Copy link
Contributor

@KaiTebay KaiTebay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@ghost ghost temporarily deployed to preview October 20, 2022 17:20 Inactive
@dngray dngray dismissed jonaharagon’s stale review October 22, 2022 04:01

Requested by Jonah

@jonaharagon jonaharagon self-requested a review October 22, 2022 04:02
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
docs/ios/configuration.en.md Outdated Show resolved Hide resolved
@ghost ghost temporarily deployed to preview October 22, 2022 06:22 Inactive
dngray pushed a commit that referenced this pull request Oct 22, 2022
Co-authored-by: Morten Lautrup <44033709+purtual@users.noreply.github.com>
Co-authored-by: matchboxbananasynergy <107055883+matchboxbananasynergy@users.noreply.github.com>
Co-authored-by: Jonah Aragon <jonah@triplebit.net>
Co-authored-by: Kai Tebay <95620167+KaiTebay@users.noreply.github.com>
Signed-off-by: Daniel Gray <dng@disroot.org>
@dngray dngray temporarily deployed to preview October 22, 2022 06:25 Inactive
Co-authored-by: Morten Lautrup <44033709+purtual@users.noreply.github.com>
Co-authored-by: matchboxbananasynergy <107055883+matchboxbananasynergy@users.noreply.github.com>
Co-authored-by: Jonah Aragon <jonah@triplebit.net>
Co-authored-by: Kai Tebay <95620167+KaiTebay@users.noreply.github.com>
Signed-off-by: Daniel Gray <dng@disroot.org>
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/v2-28/8091/1

IkelAtomig pushed a commit to IkelAtomig/privacyguides.org that referenced this pull request Nov 11, 2022
Co-authored-by: Morten Lautrup <44033709+purtual@users.noreply.github.com>
Co-authored-by: matchboxbananasynergy <107055883+matchboxbananasynergy@users.noreply.github.com>
Co-authored-by: Jonah Aragon <jonah@triplebit.net>
Co-authored-by: Kai Tebay <95620167+KaiTebay@users.noreply.github.com>
Signed-off-by: Daniel Gray <dng@disroot.org>
IkelAtomig pushed a commit to IkelAtomig/privacyguides.org that referenced this pull request Nov 13, 2022
Co-authored-by: Morten Lautrup <44033709+purtual@users.noreply.github.com>
Co-authored-by: matchboxbananasynergy <107055883+matchboxbananasynergy@users.noreply.github.com>
Co-authored-by: Jonah Aragon <jonah@triplebit.net>
Co-authored-by: Kai Tebay <95620167+KaiTebay@users.noreply.github.com>
Signed-off-by: Daniel Gray <dng@disroot.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:guides full-length guides and content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants